Unsigned types behavior #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @awalter17 ! I like it for being more consistent. It has a potentially big impact though on existing code and I would therefore like to hear the opinions of @tpietzsch @StephanPreibisch @tinevez . |
|
Hi all. |
|
Thanks for the feedback, @tinevez! I spoke with @axtimwalde and @tpietzsch yesterday as well, and they agree that this is a good change. So I'll bug @tpietzsch today to merge it. 😄 |
|
Thanks @awalter17 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! These changes implement the masking behavior for the variable constructors in UnsignedByteType, UnsignedIntType, and UnsignedShortType as discussed in issue #95. The changes also include the corresponding regression tests for the masking behavior.
Please let me know your thoughts on these changes, and thank you in advance for any feedback!