Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cimgui to 1.53.1 #119

Merged
merged 42 commits into from May 14, 2018
Merged

Commits on Apr 29, 2018

  1. Update cimgui to 1.53.1

    Update cimgui, fixing imgui-rs#97 and imgui-rs#88.
    
    As a side note, the previous version has some compiler warning showing
    up during build:
    
    warning: third-party/cimgui/imgui/imgui.cpp: In function ‘void ImGui::RenderTriangle(ImVec2, ImGuiDir, float)’:
    warning: third-party/cimgui/imgui/imgui.cpp:3136:11: warning: this statement may fall through [-Wimplicit-fallthrough=]
    warning:          r = -r; // ...fall through, no break!
    warning:          ~~^~~~
    
    The new version has no warning.
    malikolivier committed Apr 29, 2018
    Copy the full SHA
    ddd7f7e View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    817ecc2 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    cf15d49 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    1d10578 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    0c71370 View commit details
    Browse the repository at this point in the history
  6. [cimgui 1.53.1] Rename ImGuiTreeNodeFlags::AllowOverlapMode to ImGuiT…

    …reeNodeFlags::AllowItemOvelap
    malikolivier committed Apr 29, 2018
    Copy the full SHA
    a5ed022 View commit details
    Browse the repository at this point in the history
  7. imgui-sys: Fix binding to igIsWindowFocused

    This commit adds the `ImGuiFocusedFlags' input flag that was missing.
    malikolivier committed Apr 29, 2018
    Copy the full SHA
    24c3729 View commit details
    Browse the repository at this point in the history
  8. [cimgui 1.53.1] Obsolete sys::igIsRootWindowFocused()

    Should use `sys::igIsWindowFocused(ImGuiFocusedFlags_RootWindow)`
    instead.
    malikolivier committed Apr 29, 2018
    Copy the full SHA
    f3e994f View commit details
    Browse the repository at this point in the history
  9. [cimgui 1.53.1] Obsolete sys::igIsRootWindowOrAnyChildFocused()

    Should use `igIsWindowFocused(ImGuiFocusedFlags::RootAndChildWindows)`
    instead.
    malikolivier committed Apr 29, 2018
    Copy the full SHA
    2df079e View commit details
    Browse the repository at this point in the history
  10. [cimgui 1.53.1] Obsolete igIsRootWindowOrAnyChildHovered()

    Update struct for ImGuiHoveredFlags.
    
    NB: igIsWindowHovered, and thus igIsRootWindowOrAnyChildHovered, are
    broken now because of a bug.
    The fix is commited upstream, but not released yet.
    cimgui/cimgui@baebcfc
    
    I guess nothing can be done but wait for the next cimgui release.
    malikolivier committed Apr 29, 2018
    Copy the full SHA
    8d3e1a8 View commit details
    Browse the repository at this point in the history
  11. [cimgui 1.53.1] Obsolete igSetNextWindowContentWidth

    There is a small change of behaviour: previous height value is not
    preserved when igSetNextWindowContentWidth is used. There is no way
    around it unless we mess with imgui's internals.
    
    Official Dear ImGui chose this easy solution as well:
    
        static inline void SetNextWindowContentWidth(float w) { SetNextWindowContentSize(ImVec2(w, 0.0f)); }
    
    https://github.com/ocornut/imgui/blob/429f48bb4fa7fdffdb996e4a697d6df48babe3eb/imgui.h#L1132
    malikolivier committed Apr 29, 2018
    Copy the full SHA
    d2e6d41 View commit details
    Browse the repository at this point in the history
  12. [cimgui 1.53.1] Rename ImGuiTextBuffer_append() to appendf()

    This commit does not include deprecation warning.
    Indeed, defining a `ImGuiTextBuffer_append` function with a deprecation
    warning would require to write a variadic function in rust. However,
    this is impossible, and the FFI rust doc says so:
    https://doc.rust-lang.org/book/first-edition/ffi.html#variadic-functions
    
    Dear ImGui did not deprecate `append()`, they simply renamed it too.
    malikolivier committed Apr 29, 2018
    Copy the full SHA
    37b60a5 View commit details
    Browse the repository at this point in the history
  13. [cimgui 1.53.1] DrawList: Remove anti_aliased: bool final parameter

    There is no way I know of to make a deprecation warning in such a case.
    Code that uses ImDrawList_AddPolyline or ImDrawList_AddConvexPolyFilled will
    break.
    malikolivier committed Apr 29, 2018
    Copy the full SHA
    dbc9689 View commit details
    Browse the repository at this point in the history
  14. Copy the full SHA
    d4eb0fd View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2018

  1. [cimgui 1.53.1] Rename ChildWindowRounding to ChildRounding

    Add deprecation warning for each renamed variant.
    
    However, it will just fail to compile if the deprecated variant is used
    inside a match statement. It is not possible to make aliases of variants
    in Rust.
    malikolivier committed Apr 30, 2018
    Copy the full SHA
    3b231d9 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    adfa447 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    112d211 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    5bf3eff View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    b7bb27f View commit details
    Browse the repository at this point in the history
  6. [cimgui 1.53.1] test_window_impl: Add "No close" window option

    Here is the original commit in Dear ImGui implementating the "No close"
    button:
    
    ocornut/imgui@20ba79aa5
    malikolivier committed Apr 30, 2018
    Copy the full SHA
    49ab5c5 View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    bba3e58 View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    286c54a View commit details
    Browse the repository at this point in the history
  9. Copy the full SHA
    5df5806 View commit details
    Browse the repository at this point in the history
  10. Copy the full SHA
    85bb975 View commit details
    Browse the repository at this point in the history
  11. Copy the full SHA
    abd3959 View commit details
    Browse the repository at this point in the history
  12. Copy the full SHA
    2103da1 View commit details
    Browse the repository at this point in the history
  13. Copy the full SHA
    8ec33c5 View commit details
    Browse the repository at this point in the history
  14. Copy the full SHA
    d0543bb View commit details
    Browse the repository at this point in the history

Commits on May 1, 2018

  1. Copy the full SHA
    e52193b View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    4b788d0 View commit details
    Browse the repository at this point in the history
  3. [cimgui 1.53.1] Add new combo functions

    Move igCombo{1,2,3} into the combo group along with igBeginCombo and
    igEndCombo.
    malikolivier committed May 1, 2018
    Copy the full SHA
    db5059d View commit details
    Browse the repository at this point in the history
  4. [cimgui 1.53.1] Allow access to ImDrawListSharedData

    Add binding to igGetDrawListDrawData and igGetOverlayDrawList.
    malikolivier committed May 1, 2018
    Copy the full SHA
    c016ed6 View commit details
    Browse the repository at this point in the history
  5. [cimgui 1.53.1] Add binding to igSetItemDefaultFocus

    Group functions related to focus management together.
    malikolivier committed May 1, 2018
    Copy the full SHA
    20d40f0 View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    4eef43f View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    cd37cf9 View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    9cd0e61 View commit details
    Browse the repository at this point in the history
  9. Copy the full SHA
    e64a1cf View commit details
    Browse the repository at this point in the history
  10. [cimgui 1.53.1] Add raw bindings to drag/drop API

    Unfortunately, it seems necessary to pull a new dependency, libc, to be able
    to use size_t.
    
    Is there any alternative?
    malikolivier committed May 1, 2018
    Copy the full SHA
    b57d639 View commit details
    Browse the repository at this point in the history
  11. Copy the full SHA
    e4668f0 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2018

  1. Copy the full SHA
    0e1ec3c View commit details
    Browse the repository at this point in the history

Commits on May 8, 2018

  1. [cimgui 1.53.1] Update CHANGELOG

    Follow "keep a changelog" specification.
    
    https://keepachangelog.com/en/1.0.0/
    malikolivier committed May 8, 2018
    Copy the full SHA
    fc4245c View commit details
    Browse the repository at this point in the history

Commits on May 14, 2018

  1. [cimgui 1.53.1] StyleVar: Add missing WindowBorderSize

    Use WindowBorderSize as replacement for border boolean in window.rs
    malikolivier committed May 14, 2018
    Copy the full SHA
    500e64d View commit details
    Browse the repository at this point in the history