[feat-5] 모든 Error Function Customize 지원하기 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
모든 error에 대해서 customizing 가능하도록 수정
iml1111
requested changes
Jul 23, 2022
django_jwt_extended/config.py
Outdated
| @staticmethod | ||
| def customize_jwt_not_found(config: dict): | ||
| jwt_not_found = config.get('JWT_NOT_FOUND_MSG', 'JWT token not found') | ||
| return {'msg': jwt_not_found} |
There was a problem hiding this comment.
메시지 하나(string)가 아닌 dict를 통째로 customize 가능하게 해주셈.
또한 해당 인자를 입력받았을 때 해당인자가 json serialize가 가능한지도 validate해주셈.
물론 밑에 모든 customize 메소드에 동일하게 적용해주셈.
There was a problem hiding this comment.
추가적으로, 모든 customize 메소드가 로직 자체는 굉장히 유사한 걸 알 수 있음.
아예 인자를 빼서 for문을 돌리면서 함수를 하나로 만들어 버리는 것도 괜찮을 것 같음.
string이 아닌 dict를 customizing 하도록 변경 json serializable한지 검증 전체 error customizing 메소드 통합
print -> assertEqual로 변경
iml1111
approved these changes
Jul 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
모든 error에 대해서 customizing이 가능하도록 변경
JWT_CONFIG에 추가하는 방식으로 error customizing 지원