forked from mozilla/hubs
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authorization scopes & popup authorization dialog #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the actually granted scopes
…act ui options: post, view friends, update profile
- Change from redirect-based OAuth to a popup window - Update react UX to show login prompt and hide immers chat panel before login - Refactor auth & initialization flow to work with popup - Update scope upgrade flow to work with popup - Fix duplicate copies of scope accumulating in store - Fix home immer showing inaccurate scope upgrade notices - Change pass-your-handle-through-links to use hash because we no longer update the query during redirect - Prefill handle in login form when renewing expired token on remote immer
wmurphyrd
changed the title
Authorization scopes
Authorization scopes & popup authorization dialog
May 7, 2021
quinn-madson
approved these changes
May 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration with the new authorizatoin scopes from immers-space/immers#29
Update 5/7 - I finished the OAuth popup work and it included a couple bugfixes for the scopes, so I just merged it in to this PR