Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authorization scopes & popup authorization dialog #40

Merged
merged 12 commits into from
May 9, 2021

Conversation

wmurphyrd
Copy link
Member

@wmurphyrd wmurphyrd commented Apr 30, 2021

Integration with the new authorizatoin scopes from immers-space/immers#29

  • Ensure we fail gracefully when requests are denied
    • Default friends list to empty array to UI doesn't crash if friends list blocked
    • Skip over activitypub avatar creation if not permitted to avoid an unhandle promise exception
    • Most other actions are left alone and will just receive a 403 and handle it
  • Update UX to inform users when an action or info isn't available
    • Immers chat posting, friends list, and profile updates show an explanatory message and prompt to re-login
    • Add friend & share selfie buttons are just hidden (couldn't figure a clean way to do the explain&prompt pattern in the 3D assets)
    • Block button label reverts to "Hide"
  • Add a configuration option for immers to choose their preferred role to request (will be default selection in dialog)

Update 5/7 - I finished the OAuth popup work and it included a couple bugfixes for the scopes, so I just merged it in to this PR

  • Change from redirect-based OAuth to a popup window
  • Update react UX to show login prompt and hide immers chat panel before login
  • Refactor auth & initialization flow to work with popup
  • Change pass-your-handle-through-links to use hash because we no longer update the query during redirect so it would just get stuck in your URL and potentially shared
  • Prefill handle in login form when renewing expired token on remote immer

Base automatically changed from hubs-cloud-april-2021 to immers-integration May 6, 2021 22:32
- Change from redirect-based OAuth to a popup window
- Update react UX to show login prompt and hide immers chat panel before login
- Refactor auth & initialization flow to work with popup
- Update scope upgrade flow to work with popup
- Fix duplicate copies of scope accumulating in store
- Fix home immer showing inaccurate scope upgrade notices
- Change pass-your-handle-through-links to use hash because we no longer update the query during redirect
- Prefill handle in login form when renewing expired token on remote immer
@wmurphyrd wmurphyrd changed the title Authorization scopes Authorization scopes & popup authorization dialog May 7, 2021
@quinn-madson quinn-madson merged commit 07effae into immers-integration May 9, 2021
@quinn-madson quinn-madson deleted the roles branch May 9, 2021 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants