OAuth2 Scopes with user control #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… scope defs between front and backend
wmurphyrd
commented
Apr 30, 2021
Comment on lines
+338
to
347
| // Auto-approve for home immer | ||
| if (client.isTrusted) { | ||
| const params = {} | ||
| const origin = new URL(req.redirectURI) | ||
| params.origin = `${origin.protocol}//${origin.host}` | ||
| // express protocol does not include colon | ||
| params.issuer = `https://${domain}` | ||
| params.scope = ['*'] | ||
| return done(null, true, params) | ||
| } |
There was a problem hiding this comment.
When logging into your home immer, scope authorization is skipped and all scopes are granted. The easiest way to test this locally is to comment out this entire isTrusted block and then you'll get the scoping dialog when logging in (clear your hubs localstorage to trigger re-authorization if you've already got a valid token)
wmurphyrd
commented
Apr 30, 2021
| break | ||
| } | ||
| if (!overlaps(requiredScope, authorizedScope)) { | ||
| res.locals.apex.authorized = false |
There was a problem hiding this comment.
All we have to do to block access on a specific request is set this flag and activitypub-express handles the rest
Fix unable to post activities from profile page
Hash emails
quinn-madson
approved these changes
May 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to limit the level of access you grant when visiting foreign immers