Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can we make XRDepthStateInit optional? #46

Open
cabanier opened this issue May 16, 2024 · 2 comments
Open

can we make XRDepthStateInit optional? #46

cabanier opened this issue May 16, 2024 · 2 comments

Comments

@cabanier
Copy link
Member

The depth sensing spec states that [XRDepthStateInit](XRDepthStateInit](https://immersive-web.github.io/depth-sensing/#dictdef-xrdepthstateinit) is required; even when the user doesn't set any values.
Can we make it optional instead?

Quest browser has it as optional and this is causing issues in three.js

/agenda can we make XRDepthStateInit optional?

@probot-label probot-label bot added the agenda label May 16, 2024
@alcooper91
Copy link

Worth a mention that the samples don't appear to be supplying the XRDepthStateInit which is causing issues for Chrome at the moment since we do require it, so if we decide not to relax this, there's an AI to update the samples: https://immersive-web.github.io/webxr-samples/proposals/phone-ar-depth.html

@alcooper91
Copy link

Note that I'm also not sure about:

even when the user doesn't set any values

based on the algorithm here that essentially requires the returned usage/format to be contained in the array, so if the arrays are empty, no depth sensing session should be started:
https://immersive-web.github.io/depth-sensing/#find-supported-configuration-combination

@Yonet Yonet removed the agenda label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants