Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing XRLightProbe.sphericalHarmonicsOrientation and XRReflectionProbe.orientation #24

Open
kearwood opened this issue Feb 5, 2020 · 1 comment

Comments

@kearwood
Copy link
Contributor

kearwood commented Feb 5, 2020

The orientation of the platform specific API's lighting estimation may not match the XRSpace orientation. XRLightProbe.sphericalHarmonicsOrientation and XRReflectionProbe.orientation were included to avoid the cost of generating rotated versions of SH and cube maps.

Rather than storing the relative orientation, perhaps the UA should generate rotated variants aligned with the XRSpace of the viewer for global lighting estimation.

@kearwood
Copy link
Contributor Author

kearwood commented Feb 5, 2020

If the UA generates cube maps, it should also generate mip maps. We should also define the cube maps to be in linear space, both for correct mip map generation and use within shaders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant