Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 3D geometry #38

Open
cabanier opened this issue Mar 20, 2023 · 10 comments
Open

Add support for 3D geometry #38

cabanier opened this issue Mar 20, 2023 · 10 comments

Comments

@cabanier
Copy link
Member

Quest room setup allows for the creation of 3D objects and we'd like to expose those like we do for planes.
For future proofing, I think we can expose them as meshes (like we do for planes). I believe Hololens already has APIs to expose the real world this way.

Should we extend the plane API or create a new mesh API that is almost identical to the plane one?

@AdaRoseCannon
Copy link
Member

/agenda

@probot-label probot-label bot added the agenda label Mar 21, 2023
@RaananW
Copy link

RaananW commented Mar 21, 2023

Babylon native has support for a similar feature that uses the same API as the plane API - https://github.com/BabylonJS/Babylon.js/blob/master/packages/dev/core/src/XR/features/WebXRMeshDetector.ts

It also extends the webxr types to support the feature - https://github.com/BabylonJS/Babylon.js/blob/master/packages/dev/core/src/LibDeclarations/webxr.nativeextensions.d.ts#L29

It is not supported on the web, of course, but it will be great to have an API to make it work in Web as well.

@cabanier
Copy link
Member Author

That's very cool that you already implemented this natively.
I made a quick replace of plane with mesh and created this spec proposal: https://cabanier.github.io/real-world-geometry/mesh-detection.html
It seems to match closely what you implemented.

@cabanier
Copy link
Member Author

cabanier commented Apr 4, 2023

It seemed that there were no objections during the meeting.
@AdaRoseCannon What do I need to do to make this an official spec/repository?

@cabanier
Copy link
Member Author

@AdaRoseCannon @himorin Can one of you make a repository for WebXR Meshes?

@cabanier
Copy link
Member Author

https://cabanier.github.io/real-world-geometry/mesh-detection.html contains an initial proposal.
During the weekly call, we discussed that an author might like to know if this API returns a fine mesh.

/facetoface discuss WebXR Mesh proposal. Do we need to flag if a mesh is fine/precise?

@AdaRoseCannon
Copy link
Member

@cabanier we already made it :)

https://github.com/immersive-web/real-world-meshing

@cabanier
Copy link
Member Author

@cabanier we already made it :)

Thanks! I moved the spec to https://immersive-web.github.io/real-world-meshing/mesh-detection.html

@himorin
Copy link
Member

himorin commented Apr 25, 2023

@cabanier we already made it :)

Thanks! I moved the spec to https://immersive-web.github.io/real-world-meshing/mesh-detection.html

oh, I've set ghaction working with index.bs. do we want to have filename other than that?

@cabanier
Copy link
Member Author

ah. Sure, I will update the repo with that filename.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants