Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default WebVRConfig options in src/main #49

Closed
cvan opened this issue Mar 24, 2016 · 1 comment
Closed

Set default WebVRConfig options in src/main #49

cvan opened this issue Mar 24, 2016 · 1 comment

Comments

@cvan
Copy link
Contributor

cvan commented Mar 24, 2016

Instead of having to manually look at the README to see the default configuration options of WebVRConfig, it'd be nice if the defaults were defined there and overridden by anything set by the user on window.WebVRConfig.

@cvan
Copy link
Contributor Author

cvan commented Mar 24, 2016

It's worth noting that this will/could change if src/main starts exporting as a module (see issue #47).

Based on what many projects do, I'd recommend this:

module.exports = function (opts) {
  return new WebVRPolyfill(opts);
};

borismus added a commit that referenced this issue Apr 6, 2016
set default `WebVRConfig` options in `src/main` and extend them based on user-defined `window.WebVRConfig` (fixes #49)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant