Node package and schema tests #15
Conversation
|
Fixes #7 |
|
Fixes #9 |
NellWaliczek
force-pushed
the
schema-definition
branch
from
a3c4fae
to
6a5a41c
Compare
NellWaliczek
force-pushed
the
node-package-and-schema-tests
branch
3 times, most recently
from
1bd77c1
to
23736fb
Compare
This removes 3 the extraneous console.warnings for each test file
NellWaliczek
force-pushed
the
node-package-and-schema-tests
branch
from
23736fb
to
4241914
Compare
package.json
Outdated
| @@ -0,0 +1,20 @@ | |||
| { | |||
| "name": "gamepad-mappings", | |||
There was a problem hiding this comment.
Color me surprised that this doesn't already exist, but even still I think something along the lines of "xr-gamepad-mappings" might be more appropriate?
There was a problem hiding this comment.
makes sense.... does that mean the repo name should be xr-gamepad-mappings?
There was a problem hiding this comment.
I don't know what npm etiquette is regarding that kind of thing, but probably?
package.json
Outdated
| @@ -0,0 +1,20 @@ | |||
| { | |||
| "name": "gamepad-mappings", | |||
| "version": "1.0.0", | |||
There was a problem hiding this comment.
Is this at a functional-enough state to be considered version 1.0.0? Don't really care what the version is, honestly, but people tend to think that "1.0" is a statement of stability/release-worthiness.
There was a problem hiding this comment.
Ah typo. I'll fix it. I meant to say 0.1.0
This PR replaces #4 and scopes the content down for ease of CR. It now only does two things: turns the repo into a node package and adds tests to validate the schema. It does not contain tests to validate the mapping files yet. That will come in a subsequent PR.
Ignore the changes to README.md; my next step is to fix up that file as part of PR #2 and I'll rebase on top once that's done.