Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues for Oculus Touch, HTC Vive, and WMR controller entries #74

Closed
wants to merge 4 commits into from

Conversation

jacobcdewitt
Copy link

Update the profiles for these controllers to reflect the order that buttons and input axes should be exposed to the JS with the latest xr-standard Gamepad mapping, which is explained here.

Also remove the entry for the menu button from the microsoft-045e-065d profile (which happens to be the Samsung Odyssey) because the spec says buttons reserved by the UA and/or platform must not be exposed.

Copy link
Member

@NellWaliczek NellWaliczek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together! I'm curious why the removal of the menu button from the Windows controllers. Did something change that makes that button no longer accessible by webpages?

@jacobcdewitt
Copy link
Author

I removed the entry from the menu button for Windows controllers because I don't think it should be exposed to the JS. For example, Chrome does not expose the Windows menu button on WebXR gamepads.

This is based on the spec text "Buttons reserved by the UA or platform MUST NOT be exposed." from https://raw.githubusercontent.com/immersive-web/webxr-gamepads-module/master/index.bs

@jacobcdewitt
Copy link
Author

@toji - Can you double-check that we shouldn't be exposing a menu button for controllers?

@NellWaliczek
Copy link
Member

@thetuvix, can you weigh in on the menu button? In the WebVR timeframe, it was exposed to developers and I'd like to confirm this change is intentional

@NellWaliczek
Copy link
Member

Hey @jacobcdewitt can you rebase this on top of #78 if anything still needs fixing?

@jacobcdewitt
Copy link
Author

Hey @jacobcdewitt can you rebase this on top of #78 if anything still needs fixing?

I looked at #78 and I see it fixes the button ordering issues for the controllers updated in this pull request. However, per my comments in that pull request, I'm not sure if we should have any entries for menu buttons. That can be addressed in #78 , so I'm closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants