New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: reduce docker image size #1523
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Deployment failed with the following error:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 🎉
77374e4
to
db9de22
Compare
Deployment failed with the following error:
|
db9de22
to
a7352a5
Compare
@@ -58,6 +58,7 @@ | |||
"cookie-parser": "^1.4.6", | |||
"diskusage": "^1.1.3", | |||
"exiftool-vendored": "^19.0.0", | |||
"exiftool-vendored.pl": "^12.54.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope you are aware that this is not meant to be used directly as a dep?
"You shouldn't include either the exiftool-vendored.exe or exiftool-vendored.pl as direct dependencies to your project." - https://www.npmjs.com/package/exiftool-vendored install section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we looked at this. That works fine, but we are specifically running npm ci --omit=optional
to decrease the number of unused packages that are installed on the docker image. Unfortunately this is marked as an optional and there really isn't a way around getting it installed without listing it as a dependency or installing all our optional deps.
Reduces machine-learning docker image size from 2.4GB to ~850MB
Reduces server docker image size from 505MB to ~350MB
Reduces web docker image size from 350MB to ~ 150MB