Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: npm i on Windows … #8619

Merged
merged 2 commits into from
Apr 8, 2024
Merged

fix: npm i on Windows … #8619

merged 2 commits into from
Apr 8, 2024

Conversation

jellemdekker
Copy link
Contributor

…by removing direct dependency on exiftool-vendored.pl (like in e2e/package.json)

As platform-specific optional dependency will be provided by exiftool-vendored dependency: https://github.com/photostructure/exiftool-vendored.js/blob/9d4c1543c30d1466d035edbca22475b53523c98a/README.md?plain=1#L72-L74

@jellemdekker
Copy link
Contributor Author

jellemdekker commented Apr 8, 2024

Hmm, this was originally added in 43da8c2#diff-da00458cdaeaea2314cb0e0101c85130593048072ada62de01727958c5d6ca37R61. And noted during review.

Unfortunately, when included it does break npm i on Windows with the following error:

"C:\Program Files\nodejs\npm.cmd" install
npm ERR! code EBADPLATFORM
npm ERR! notsup Unsupported platform for exiftool-vendored.pl@12.78.0: wanted {"os":"!win32"} (current: {"os":"win32"})
npm ERR! notsup Valid os:  !win32
npm ERR! notsup Actual os: win32

npm ERR! A complete log of this run can be found in: C:\Users\User1\AppData\Local\npm-cache\_logs\2024-04-08T09_30_18_297Z-debug-0.log

Process finished with exit code 1

@jrasm91 jrasm91 requested a review from mertalev April 8, 2024 14:46
Copy link
Contributor

@mertalev mertalev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@mertalev mertalev merged commit 29e47dd into immich-app:main Apr 8, 2024
23 checks passed
@jellemdekker jellemdekker deleted the fix/exiftool-vendored_dependency_on_windows branch April 10, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants