Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mobile): load server result assets from local DB #5971

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

fyfrey
Copy link
Contributor

@fyfrey fyfrey commented Dec 25, 2023

with this PR server asset results (person/face assets, map assets, memories) are fetched from isar DB, thereby using the local assets if available (just like it is already done for search results)

fix #3782

Copy link
Member

@shenlong-tanwen shenlong-tanwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. LGTM

@alextran1502 alextran1502 merged commit 733fa28 into main Dec 26, 2023
21 of 22 checks passed
@alextran1502 alextran1502 deleted the dev/mobile-search-retrieve-from-isar branch December 26, 2023 21:41
l0nax added a commit to l0nax/immich that referenced this pull request Dec 28, 2023
Instead of requesting the server for the relevant entries, we can use
the local DB.

This change fixes loading errors when going to the "Live-Images" page.
It is similar to the work done with immich-app#5971.
l0nax added a commit to l0nax/immich that referenced this pull request Dec 28, 2023
Instead of requesting the server for the relevant entries, we can use
the local DB.

This change fixes loading errors when going to the "Live-Images" page.
It is similar to the work done with immich-app#5971.
alextran1502 pushed a commit that referenced this pull request Dec 28, 2023
* fix(mobile): Load assets on "Live-Images" page

Instead of requesting the server for the relevant entries, we can use
the local DB.

This change fixes loading errors when going to the "Live-Images" page.
It is similar to the work done with #5971.

* fix(mobile): Fix Recently added page
martabal pushed a commit that referenced this pull request Jan 9, 2024
* fix(mobile): Load assets on "Live-Images" page

Instead of requesting the server for the relevant entries, we can use
the local DB.

This change fixes loading errors when going to the "Live-Images" page.
It is similar to the work done with #5971.

* fix(mobile): Fix Recently added page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

People recognition local storage
3 participants