fix(mobile): Fix "Live Images" and "Recently added" page #6030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l0nax
changed the title
l0nax
changed the title
Instead of requesting the server for the relevant entries, we can use the local DB. This change fixes loading errors when going to the "Live-Images" page. It is similar to the work done with immich-app#5971.
l0nax
force-pushed
the
fix-mobile-live-photos
branch
from
6294a0b
to
c703890
Compare
3 tasks
alextran1502
approved these changes
Dec 28, 2023
martabal
pushed a commit
that referenced
this pull request
Jan 9, 2024
* fix(mobile): Load assets on "Live-Images" page Instead of requesting the server for the relevant entries, we can use the local DB. This change fixes loading errors when going to the "Live-Images" page. It is similar to the work done with #5971. * fix(mobile): Fix Recently added page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the error when going to the Live Images page on the mobile app.
The reason why some of the category pages do not work anymore on mobile is due to a change made with 1e99ba8: The server always expects a non-empty query:
immich/server/src/domain/search/search.service.ts
Lines 58 to 61 in 27bc777
The behavior is the same with the Recently Added page.
And it seems that the
recentparameter of thesearchAPI endpoint is now a no-op. Is this intentional?Related #5971