Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web): copy shared link #6309

Merged
merged 1 commit into from
Jan 10, 2024
Merged

fix(web): copy shared link #6309

merged 1 commit into from
Jan 10, 2024

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented Jan 10, 2024

Closes #6280

  • Only copy the link (not the password) and
  • Fix resolving domain name with trailing slash

@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented Jan 10, 2024 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 26bb719
Status:⚡️  Build in progress...

View logs

@alextran1502 alextran1502 enabled auto-merge (squash) January 10, 2024 04:03
@alextran1502 alextran1502 merged commit 08fcce9 into main Jan 10, 2024
20 of 21 checks passed
@alextran1502 alextran1502 deleted the fix/web-copy-shared-link branch January 10, 2024 04:10
@shenlong-tanwen shenlong-tanwen mentioned this pull request Jan 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextran1502 alextran1502 alextran1502 approved these changes

@danieldietzler danieldietzler Awaiting requested review from danieldietzler

Assignees
No one assigned
Labels
🖥️web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Always copy the shared link URL
2 participants
@jrasm91 @alextran1502