Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mobile): copy shared link #6310

Merged
merged 2 commits into from
Jan 10, 2024
Merged

fix(mobile): copy shared link #6310

merged 2 commits into from
Jan 10, 2024

Conversation

shenlong-tanwen
Copy link
Member

Changes made:

  • Fixes the mobile side handling to be in sync with the web client changes from fix(web): copy shared link #6309
    • Only copy the shared link URL and not the password
    • Handle trailing slash in External Domain

@cloudflare-pages Cloudflare Pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e8db5bd
Status: ✅  Deploy successful!
Preview URL: https://18dd77df.immich.pages.dev
Branch Preview URL: https://fix-mobile-copy-shared-link.immich.pages.dev

View logs

jrasm91
jrasm91 approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alextran1502 alextran1502 merged commit 4f942bc into main Jan 10, 2024
21 of 22 checks passed
@alextran1502 alextran1502 deleted the fix/mobile-copy-shared-link branch January 10, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrasm91 jrasm91 jrasm91 approved these changes

@alextran1502 alextran1502 Awaiting requested review from alextran1502

Assignees
No one assigned
Labels
📱mobile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shenlong-tanwen @jrasm91 @alextran1502