feat(server): provide the ability to search archived photos

[stevenwcarter]

Description

Adds a query parameter (withArchived) to the search URL parameters to allow the results to contain archived photos.

I commented on #5806 that it might be useful if we could optionally search archived photos, and this PR adds that ability. I'm not really a UI developer, so I've only added the ability to optionally perform this search with a query parameter for now. Eventually we might want to add radio options or magic search terms to enable searching archived/non-visible photos.

How has this been tested

• Import photos
• Perform search that returns some of those photos.
• Archive some of the returned photos.
• Repeat search and confirm the archived photos are not returned.
• Add query parameter to URL &withArchived=true
• Confirm that the previously archived photos are now returned as part of the search.

[danieldietzler]

Where is the difference to https://immich.app/docs/api/search-assets and the isArchived parameter?

[stevenwcarter]

Hm, fair point, that I might be able to exercise that existing option. The problem is that the changes made in #5806 explicitly set the archived=false check in the query, so no archived results will ever be returned without this change.

[danieldietzler]

Hm, fair point, that I might be able to exercise that existing option. The problem is that the changes made in #5806 explicitly set the archived=false check in the query, so no archived results will ever be returned without this change.

We will refactor search anyways and then I think the asset search endpoint will be the foundation for that. (it has already lots of good filters)
So I'm not sure "smart search" is even a thing that will be around much longer lol
I'll leave it to the others to decide :)

[danieldietzler]

Generally, I believe this PR does look good though

[danieldietzler]

Thank you! Great work :)

[stevenwcarter]

Do I need to clean up these conflicts in order for this to be merged? Won't most PRs cause a conflict with these build artifacts included in the repository?

[danieldietzler]

Yes, they need to be cleaned up. Since those are just generated files you should be able to just run make api again (during the rebase)

[jrasm91]

Yes, they need to be cleaned up. Since those are just generated files you should be able to just run make api again (during the rebase)

make open-api

[danieldietzler]

Yes, they need to be cleaned up. Since those are just generated files you should be able to just run make api again (during the rebase)

make open-api

Did the open api refactoring change the target?