-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added a configuration option to select the dri node in transcoding #6376
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! We expose every config option in the settings UI, so this should be added there as well.
I don't have a lot of spare time right now (hence only doing the config file part), but I will give it a shot :) |
If you don't have time I'm sure one of us can help with that part, so just let us know. |
I can try to get it done tomorrow if you'd like :) |
Sorry for the delay in the response and thanks for the offering :D Yesterday I started looking into the code of the web and I have already the option exposed, I will try to finish tonight the work and commit it. Also I am thinking that maybe this option can be used also por QSV and other acceleration APIs, but I have to check it first |
It can be used for QSV, but it would need to be tested to check that the command still works. Unlike VAAPI, we don't pass a device to the QSV command and let QSV decide what to use. |
731f952
to
8be6653
Compare
Sorry for the delay, but I haven't had any time to look into this the past week. I have exposed the option in the settings UI, rebased the branch to be in sync with the latest main commits and I have also used the option in QSVConfig to select a dri node. I have not been able to test QSV command (my hardware doesn't seems to support QSV in linux?), the ffmpeg command fails every time, but according to documentation the arguments are correct. If anyone can confirm that it is working it would be very helpful, if not, I will just revert the commit and move it to another branch. |
8be6653
to
176e81f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
1050b2d
to
4817197
Compare
9e22069
to
b2c44fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done!
This code adds a field in SystemConfigFFmpegDto to specify the node in /dev/dri used for VAAPI hardware transcoding.
The default value is auto, and in that case the VAAPIConfig config class works like up until now (it chooses the first available node in /dev/dri), but if the field is configured with a path to a dri node that exists (/dev/dri/renderD128 for example) it uses that node in the ffmpeg command in -init_hw_device parameter