Fix Notification components possible memory leaks #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dispose subscriptions and timeouts when the components are removed from the DOM
alextran1502
reviewed
Sep 9, 2022
| notificationController.notificationList.subscribe((list) => { | ||
| notificationList = list; | ||
| }); | ||
| const { notificationList } = notificationController; |
There was a problem hiding this comment.
I love this so much since I discovered I could just destruct a variable to use the Writable property directly without subscribing 😝. Thanks Jaime
There was a problem hiding this comment.
Yes very handy, and Svelte takes care of unsubscribing automatically 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dispose subscriptions and timeouts when the components are removed from the DOM.
Currently it probably doesn't create memory leaks since the NotificationList is shown in the base layout as a singleton component. But if at some point we add a feature to dismiss a notification on click, then it might create a memory leak.
Added affected components tests to validate changes.