-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: stop cli tests from reading server source #6711
Conversation
a606cfb
to
5a4ace5
Compare
Looks good for the most part, but do we really want to move the api e2e to the tests folder? |
Node versions below 20.8 usually core dump when running tests, if you want a hint for debugging the failing test |
#6719 should fix the core dump issue btw. No need to specify the node version, etc. |
We need the e2e api to be compiled because it's shared by the server and CLI projects. Currently the CLI project depends on the e2e api source code, which means the CLI project depends on the source code of the whole server project rather than the compiled output. We can put it in a different directory like
Thanks! The tests are passing now by switching to Node 20
Sure, that works too. Though I was hoping to replace Jest with Vitest (#6678) after this PR is merged, which would let us run on Node 18 again without issue or needing to mock anything. |
closing in favor of #6747 |
as suggested in #6678 (comment). this should unblock the vitest migration for the CLI project