Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: no experimental vm modules #6719

Merged
merged 1 commit into from
Jan 29, 2024
Merged

refactor: no experimental vm modules #6719

merged 1 commit into from
Jan 29, 2024

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented Jan 29, 2024

Remove the need for using --experimental-vm-modules due to dynamic import (for es module) by mocking the thumbhash implementation.

Copy link

cloudflare-pages bot commented Jan 29, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e632a10
Status: ✅  Deploy successful!
Preview URL: https://358b277c.immich.pages.dev
Branch Preview URL: https://refactor-e2e-4.immich.pages.dev

View logs

Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alextran1502 alextran1502 merged commit 6dca47c into main Jan 29, 2024
25 checks passed
@alextran1502 alextran1502 deleted the refactor/e2e-4 branch January 29, 2024 15:11
@etnoy
Copy link
Contributor

etnoy commented Jan 29, 2024

Awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants