fix: shell scripts

[martabal]

Fix shell scripts which don't respect shellcheck syntax.

Files found with this command : find ./ -type f -name "*.sh" -not \( -path "**/open-api/**" -o -path "**/openapi/**" -o -path "**/node_modules/**" \) -exec shellcheck --format=gcc {} \;

The pump-version.sh script bump the web version too.

[martabal]

I don't know if it's worth adding a CI job for this

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Pages

Latest commit:	5f1738d
Status:	✅  Deploy successful!
Preview URL:	https://a675b987.immich.pages.dev
Branch Preview URL:	https://fix-bash-scripts.immich.pages.dev

View logs

[mertalev]

Nice! I think a check would be fine if you'd like to add one

[danieldietzler]

So it isn't considered good practice to assign a value to an env variable directly? (without an intermediate variable)

[martabal]

So it isn't considered good practice to assign a value to an env variable directly? (without an intermediate variable)

Yes, if you use export https://www.shellcheck.net/wiki/SC2155

[mertalev]

In the original code, the return value of mycmd is ignored, and export will instead always return true. This may prevent conditionals, set -e and traps from working correctly.

Oh wow, I didn't know it ignored return values.