feat(web): configure slideshow #7219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martabal
changed the title
Deploying with
|
| Latest commit: |
26adfd4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f561c2e1.immich.pages.dev |
| Branch Preview URL: | https://feat-configure-slideshow-del.immich.pages.dev |
martabal
changed the title
jrasm91
reviewed
Feb 22, 2024
| </script> | ||
|
|
||
| <span class="absolute left-0 h-[3px] bg-immich-primary shadow-2xl" style:width={`${$progress * 100}%`} /> | ||
| {#if $showProgressBar} |
There was a problem hiding this comment.
This means the component cannot be used anywhere else, since it's functionality is now coupled with the this slideshow setting.
|
I've updated it to have a settings modal, similar to the map. It seems more consistent. I've also moved the shuffle setting into the same place now (less buttons on the screen all the time).
|
jrasm91
force-pushed
the
feat/configure-slideshow-delay
branch
from
f5aebea
to
7338439
Compare
alextran1502
approved these changes
Feb 23, 2024
danieldietzler
pushed a commit
that referenced
this pull request
Feb 23, 2024
* feat: configure slideshow delay * feat: show/hide progressbar * fix: slider * refactor: use grid instead of flex * fix: default delay * refactor: progress bar props * refactor: slideshow settings * fix: enforce min/max value * chore: linting --------- Co-authored-by: Jason Rasmussen <jrasm91@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to configure the slideshow delay and show / hide the progress bar
Screenshots
2024-02-20.19-15-25.mp4