Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): don't ask password for invalid shared link #7456

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

michelheusschen
Copy link
Contributor

Show Invalid share key message (passed through from server) instead of asking for password input for invalid shared links. Also adds e2e tests for this

invalid-shared-link-error

Copy link

cloudflare-workers-and-pages bot commented Feb 27, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9d9a6d5
Status: ✅  Deploy successful!
Preview URL: https://8e7f1b90.immich.pages.dev
Branch Preview URL: https://fix-web-shared-link-password.immich.pages.dev

View logs

Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

e2e/src/web/specs/shared-link.e2e-spec.ts Outdated Show resolved Hide resolved
@alextran1502 alextran1502 merged commit 21feb69 into main Feb 27, 2024
25 checks passed
@alextran1502 alextran1502 deleted the fix/web-shared-link-password branch February 27, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants