perf(web): optimize date groups #7593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
6b98bbd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d5ac90d3.immich.pages.dev |
| Branch Preview URL: | https://perf-web-date-group-optimiza.immich.pages.dev |
|
Does this solve issue #5030 ? |
No, that one is because we only do a rough estimate of height initially and update as we fetch the assets. The justified layout makes it hard to get it exact. There's probably room for improvement there though. |
michelheusschen
added a commit
that referenced
this pull request
Mar 5, 2024
This reverts commit 762c468.
alextran1502
pushed a commit
that referenced
this pull request
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The algorithm for grouping by date is inefficient and doesn't scale well. There's also no caching, so revisiting buckets re-groups again. This PR optimizes this with a more efficient algorithm and ensures that a given bucket will only ever be grouped into dates once.
How Has This Been Tested?
Tested with a console log during grouping to check that a given bucket is only grouped once, even after scrubbing away and back to the bucket.