Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "perf(web): optimize date groups" #7638

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

michelheusschen
Copy link
Contributor

After #7593 got merged I noticed some issues:

  • Updating assets after an upload fails (except upload into a new bucket)
  • AssetStore.removeAssets no longer updates UI state (except deleting all assets in a bucket)
  • From code it looks like assets and date groups are no longer being sorted and just depend on insertion order

Quite a few things have been overlooked and I think this PR should be reverted

@alextran1502
Copy link
Contributor

We will also need to revert #7563

@mertalev are you still working on this to find the cause or you are OK reverting and return to this matter at a later time?

@mertalev
Copy link
Contributor

mertalev commented Mar 5, 2024

I don't have the time to look into this more right now, so we can revert it and look at it later.

@alextran1502 alextran1502 merged commit facd0bc into main Mar 5, 2024
25 of 26 checks passed
@alextran1502 alextran1502 deleted the revert-7593-perf/web-date-group-optimization branch March 5, 2024 15:43
@mertalev
Copy link
Contributor

mertalev commented Mar 5, 2024

From code it looks like assets and date groups are no longer being sorted and just depend on insertion order

This part was intentional since the time bucket response already returns assets in sorted order. Re-sorting everything is a waste.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants