perf(server): use queries to refresh library assets #7685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
361eac1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://48085978.immich.pages.dev |
| Branch Preview URL: | https://perf-library-asset-refresh.immich.pages.dev |
alextran1502
approved these changes
Mar 7, 2024
aviv926
pushed a commit
to aviv926/immich
that referenced
this pull request
Mar 7, 2024
* use queries instead of js * missing await * add mock methods * fix test * update sql * linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current implementation fetches all assets for a library, which is slow and uses a substantial amount of memory. This PR moves this logic to optimized queries instead.
Fixes #7373