fix(server): external library sync not working for large libraries #7759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
996d9fa
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f60054ab.immich.pages.dev |
| Branch Preview URL: | https://fix-external-library-sync.immich.pages.dev |
mertalev
force-pushed
the
fix/external-library-sync
branch
from
ccb3300
to
5b3a17a
Compare
3 tasks
etnoy
approved these changes
Mar 10, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The earlier improvement in #7685 only works correctly up to 65k assets. This PR changes the implementation to receive paginated assets and keep track of which are online / offline / new. At the end, online and offline assets have their state updated and new assets are scanned. This is a bit slower than #7685, but works with large libraries and should still use little memory.