fix(web): closing asset viewer #8933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying immich with
|
| Latest commit: |
b4507d0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e1643f8f.immich.pages.dev |
| Branch Preview URL: | https://fix-stack-interaction-naviga.immich.pages.dev |
martabal
force-pushed
the
fix/stack-interaction-navigation
branch
from
09e6fec
to
c985615
Compare
|
Can you help explain on why are we having this issue? |
Of course ! It's because the stack is part of a group with a z-index inferior to the divs used for the navigation. The solution is just to remove the stack from that group and since it's using an absolute position it does not affect the look or the behavior. |
Closed
3 tasks
|
I think this PR is superseded by #8998, correct? |
martabal
changed the title
danieldietzler
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #8932