Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): Move stack slideshow container higher in the DOM #8998

Merged

Conversation

Snowknight26
Copy link
Contributor

This removes the need to define a bottom margin on the next/previous navigation elements, and renders the stack slideshow above the navigation elements, so that the stack slideshow is always interactable.

Probably fixes #8928.

@Snowknight26 Snowknight26 changed the title Move stack slideshow container higher in the DOM fix(web): Move stack slideshow container higher in the DOM Apr 21, 2024
@Snowknight26
Copy link
Contributor Author

Whoopsies, thought I was making this PR on my forked repo, but oh well, let's roll with it. Haven't tested it because I don't really know Svelte.

Copy link
Contributor

@alextran1502 alextran1502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and easy, thank you for the fix

@alextran1502 alextran1502 merged commit 0b3373c into immich-app:main Apr 25, 2024
22 of 24 checks passed
@Snowknight26 Snowknight26 deleted the fix-asset-viewer-stack-navigation branch April 25, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image viewer next image link (left arrow) covers thumbnails when viewing stacked images
2 participants