fix(web): add debounce to location search #9074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
reviewed
Apr 25, 2024
web/src/lib/components/shared-components/change-location.svelte
Outdated
Show resolved
Hide resolved
|
Can't we just abort the previous request ? |
nghduc97
commented
Apr 26, 2024
| isSearching = false; | ||
| showSpinner = false; | ||
| if (latestSearchTimeout) { | ||
| clearTimeout(latestSearchTimeout); |
There was a problem hiding this comment.
Can't we just abort the previous request ?
@martabal Yes, abort if no requests have been sent, if already sent then ignore the result.
There was a problem hiding this comment.
No, I mean using an AbortController. The timeout is used to avoid the loading spinner from blinking.
alextran1502
approved these changes
Apr 26, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The search input on change location dialog ignore changes when search is in place leading to issue #9061. This PR fixes it by adding debounce on the input.