Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change location dialog doesn't show result for latest value in search input #9061

Closed
1 of 3 tasks
nghduc97 opened this issue Apr 24, 2024 · 2 comments
Closed
1 of 3 tasks
Labels

Comments

@nghduc97
Copy link
Contributor

The bug

The change location dialog seems to show result for the previous value in the search input instead of the latest one. I recorded the demo on the demo server https://demo.immich.app/

Demo:

Photos.-.Immich.Ablaze.Floorp.2024-04-24.21-18-29-00.00.04.258-00.00.11.435-00.00.00.000-00.00.07.568.mp4

The OS that Immich Server is running on

https://demo.immich.app/

Version of Immich Server

v1.102.3

Version of Immich Mobile App

v1.102.3

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

Irrelevant

Your .env content

Irrelevant

Reproduction steps

1. Select a photo/video
2. Select "Change Location" in the drop down menu
3. Type `Hanoi` in the search input and wait for result -> this shows "Hong Kong" as result
4. Type a space to the search input to have `Hanoi ` -> shows correct result
...

Relevant log output

No response

Additional information

No response

@bo0tzz
Copy link
Member

bo0tzz commented Apr 24, 2024

It seems to me like any changes to the field while it's loading results are not taken into account. There should probably be some debounce on the input, and a cancellation of ongoing loads if the field is changed.

@alextran1502
Copy link
Contributor

Fixed in #9074

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants