Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): standardize CircleIconButton colors #9127

Merged
merged 3 commits into from
Apr 27, 2024

Conversation

ben-basten
Copy link
Member

@ben-basten ben-basten commented Apr 27, 2024

Description

Standardizing the color theming of the CircleIconButton component by adding a set of color presets. The styling was also moved completely over to Tailwind, which allows for easier customization for specific use cases via the class component prop. These changes were modeled after the Button component.

A new "primary" color option was also added, for use in the "User Management" settings.

The goal here is to make the component easier to implement in a reproducible way. Allowing free color input as props allows for inconsistencies in look, and requires digging through other implementations of the component to find acceptable color hex codes. After this change, all that developers need to do to implement this component for most use cases is choose a title, color theme, and icon.

Screenshots

N/A - user interface should look the same as before.

How Has This Been Tested?

Check that the buttons look as expected in light mode, light mode hovered, dark mode, and dark mode hovered.

Notable edge case icons to check:

  • asset viewer nav bar
  • nav bar in full screen views, such as the album page
  • memory lane buttons (close, next memory, previous memory, show gallery, hide gallery)
  • "Send message" button in album chat
  • Album sharing option buttons
  • Admin "User Management" buttons
  • "Close" button when downloading assets

Checklist:

  • npm run lint
  • npm run format
  • npm run check:svelte
  • npm test

@ben-basten ben-basten marked this pull request as ready for review April 27, 2024 22:06
@jrasm91 jrasm91 enabled auto-merge (squash) April 27, 2024 22:29
@jrasm91 jrasm91 merged commit 19aa97d into immich-app:main Apr 27, 2024
22 of 27 checks passed
@ben-basten ben-basten deleted the feat/circle-icon-button-theming branch April 27, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants