Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): remove CircleIconButton slot #9131

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

ben-basten
Copy link
Contributor

Description

Follow up for #9127 that I meant to include.

The CircleIconButton functionality isn't designed to take content in a slot and display it in a helpful way. This PR removes this slot to simplify future usage of the component.

Screenshots

N/A - user interface should look the same as before.

Checklist:

  • npm run lint
  • npm run format
  • npm run check:svelte
  • npm test

@jrasm91 jrasm91 enabled auto-merge (squash) April 28, 2024 03:06
@jrasm91 jrasm91 merged commit 13e093b into immich-app:main Apr 28, 2024
22 of 23 checks passed
@ben-basten ben-basten deleted the chore/circle-icon-button-slot branch April 28, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants