Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: New Futo milestones #9211

Merged
merged 6 commits into from
May 2, 2024
Merged

Conversation

aviv926
Copy link
Contributor

@aviv926 aviv926 commented May 1, 2024

Because this is a change that is immediately going on I have linked it to release: 'V1.103.0',

image

@aviv926 aviv926 added the documentation Improvements or additions to documentation label May 1, 2024
} from '@mdi/js';
import Layout from '@theme/Layout';
import React from 'react';
import Timeline, { DateType, Item } from '../components/timeline';

const items: Item[] = [
{
icon: mdiHandshakeOutline,
description: 'Joining Futo and Immich core team goes full-time',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Joined

@zackpollard
Copy link
Contributor

I have made a PR #9212 to allow not specifying the release as well as the tag which will remove the top right element of the milestone.

@zackpollard zackpollard enabled auto-merge (squash) May 2, 2024 00:43
@zackpollard zackpollard merged commit 4b86c7a into immich-app:main May 2, 2024
25 checks passed
icon: mdiHandshakeOutline,
description: 'Joined Futo and Immich core team goes full-time',
title: 'Immich joins FUTO!',
date: new Date(2024, 4, 1),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2024-04-01, or 2024-05-01?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In javascript, months are 0-indexed, so 4-1 is correct and as you can see in the screenshot shows the correct date.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, so silly of me. my bad 😅

@aviv926
Copy link
Contributor Author

aviv926 commented May 2, 2024

I have made a PR #9212 to allow not specifying the release as well as the tag which will remove the top right element of the milestone.

Thanks Zack!

@aviv926 aviv926 deleted the add-to-timeline branch May 2, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants