fix(server): nvenc not working when there are no filters #9802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying immich with
|
| Latest commit: |
1e41290
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3ae5bbc9.immich.pages.dev |
| Branch Preview URL: | https://fix-server-nvenc-no-filters.immich.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The code currently adds
format=nv12if there is no filter, but this makes FFmpeg throw an error. Omitting it works for both HDR and SDR inputs, so there's no need for it.How Has This Been Tested?
Tested on a video that was throwing an error with
format=nv12, confirming that it works when omitted. Also tested on an HDR video that still worked without this.