Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): unique ID generation #9932

Merged
merged 4 commits into from
Jun 1, 2024

Conversation

ben-basten
Copy link
Member

Description

Added a unique ID generation utility, which removes the need to include IDs as props in many scenarios.

How Has This Been Tested?

Tested modals, toggles, and comboboxes with a screen reader to make sure that the aria attributes are still announcing as expected. Also inspected the HTML to make sure that the generated IDs are unique.

@alextran1502 alextran1502 merged commit 01f52c9 into immich-app:main Jun 1, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants