-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): email notification preference settings #9934
Conversation
open-api/templates/mobile/serialization/native/native_class.mustache.rej
Outdated
Show resolved
Hide resolved
@ValidateBoolean({ optional: true }) | ||
albumInvite?: boolean; | ||
|
||
@ValidateBoolean({ optional: true }) | ||
albumUpdate?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we want it to be more of an object structure. So something like { album: { invite: true, update: false }, ... }
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be more on the preference's response, which is already structured somewhat similar
emailNotifications: {
enabled: true,
albumInvite: true,
albumUpdate: true,
},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw that and I don't think it's structured similarly to my suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to keep it similar to the event for ease of tracking. Additionally, you need the master enabled
flag for ease of mass toggle
web/src/lib/components/user-settings-page/notifications-settings.svelte
Outdated
Show resolved
Hide resolved
web/src/lib/components/user-settings-page/user-settings-list.svelte
Outdated
Show resolved
Hide resolved
As part of adding the information to #9930, is this PR expected to cover the option to enable or disable email notifications for specific albums? |
@aviv926 No, it doesn't. This permission covers the blanket permissions for the album. |
…gs.svelte Co-authored-by: Daniel Dietzler <36593685+danieldietzler@users.noreply.github.com>
This PR implements email notification settings for each user. The user can toggle to enable/disable the email notification entirely or selectively choose what type of email notificaton event (ALBUM INVITE, ALBUM UPDATE) to receive