Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Api changes for making project more useful #28

Merged
merged 26 commits into from
Feb 11, 2019
Merged

Api changes for making project more useful #28

merged 26 commits into from
Feb 11, 2019

Conversation

immnk
Copy link
Owner

@immnk immnk commented Jan 22, 2019

This PR Fixes issue #

Proposed Changes

image

  • Made changes to get data
  • Changes to look and feel
  • Changes to test cases
  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • [x ] Tests for the changes have been added (for bug fixes / features)
  • [x ] Docs have been added / updated (for bug fixes / features)

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    More features to look and feel

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?
    New look and feel from changed data

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    Changes to existing modules. Test cases cover them.

  • Other information:

@immnk
making api changes
0a4f90a
@immnk
Merge branch 'master' of https://github.com/immnk/webpack-testing int…
e4eeb0c 
…o api-changes-for-making-project-more-useful
@immnk
update readme for lint errors
a79f974
@immnk
more changes for readme
9b37e57
@immnk
Merge branch 'master' of https://github.com/immnk/webpack-testing int…
7778ae1 
…o api-changes-for-making-project-more-useful
@immnk
Merge branch 'api-changes-for-making-project-more-useful' of https://…
f0dfc75 
…github.com/immnk/webpack-testing into api-changes-for-making-project-more-useful
@immnk
#23 - commit for working JSON loading via templating
cb812a0
@immnk
#23 - change css styles
34832e4
@immnk
changes to module naming - Issue #23
fe7fc44
@immnk
fix es lint #23
3b8d9f5
@immnk
make more styling changes and data #23
0699ef9
@immnk
change test cases for api changes #23
920daae
@immnk
#23 - writing DOM manipulation modules with unit tests
7c70b9b
@immnk
#23 - fix coveralls
8db5dce
@immnk
#23 - run coverage before prod build so not to miss source maps
7c8e86c
@immnk
#23 - revert package
41507fe
@immnk
#23 - change for passing test
0fce3d8
@immnk
#23 - test nyc coverage
6eb86f8
@immnk
#23 - fix issues and add learnings
054670d
@immnk immnk self-assigned this Jan 22, 2019
@immnk immnk added feature New feature that is not present in the system build build related issues are addressed with build label labels Jan 22, 2019
@immnk immnk added this to the Dashboard Screen milestone Jan 22, 2019
@immnk immnk closed this Jan 23, 2019
@immnk immnk reopened this Jan 23, 2019
@immnk immnk closed this Jan 23, 2019
@immnk immnk reopened this Jan 23, 2019
@coveralls
Copy link

coveralls commented Jan 23, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 35

  • 20 of 20 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-4.2%) to 95.833%
Totals Coverage Status
Change from base Build 3: -4.2%
Covered Lines: 22
Relevant Lines: 22
💛 - Coveralls

aradhanagate
aradhanagate previously approved these changes Feb 11, 2019
View reviewed changes
Copy link
Collaborator

@aradhanagate aradhanagate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@immnk immnk closed this Feb 11, 2019
@immnk immnk reopened this Feb 11, 2019
@immnk immnk closed this Feb 11, 2019
@immnk immnk reopened this Feb 11, 2019
@immnk immnk merged commit 88912ad into master Feb 11, 2019
@immnk immnk mentioned this pull request Feb 11, 2019
Closed
@immnk immnk deleted the api-changes-for-making-project-more-useful branch February 12, 2019 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aradhanagate aradhanagate aradhanagate approved these changes

Assignees

@immnk immnk

Labels
build build related issues are addressed with build label feature New feature that is not present in the system
Projects
None yet
Milestone
Dashboard Screen
Development

Successfully merging this pull request may close these issues.
3 participants
@immnk @coveralls @aradhanagate