Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default to AT&T dialect, add hint for Intel #405

Merged
merged 1 commit into from
May 13, 2022
Merged

default to AT&T dialect, add hint for Intel #405

merged 1 commit into from
May 13, 2022

Conversation

aneksteind
Copy link
Contributor

addresses #397

fw-immunant
fw-immunant approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@fw-immunant fw-immunant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. At some point it might be worth trying to check for -masm=<intel|att> in the command line for the current file to determine the default behavior, but this is more correct in the absence of any flags.

@aneksteind
Copy link
Contributor Author

LGTM. At some point it might be worth trying to check for -masm=<intel|att> in the command line for the current file to determine the default behavior, but this is more correct in the absence of any flags.

Agreed, I'm looking into something along those lines

@aneksteind aneksteind merged commit 007dfe6 into master May 13, 2022
@aneksteind aneksteind deleted the fix.asm.att branch July 12, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fw-immunant fw-immunant fw-immunant approved these changes

@rinon rinon Awaiting requested review from rinon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aneksteind @fw-immunant