transpile: allow stabilized const integer arithmetic methods #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wrapping arithmetic methods on unsigned integers are stably const now.
kkysen
reviewed
Jul 15, 2022
kkysen
approved these changes
Jul 17, 2022
There was a problem hiding this comment.
On second thought, I think this is a change we want regardless of if rustc can compile the resultant code. We shouldn't prematurely decide if it can or cannot, as rustc will likely give a much better error message anyways, and it's more future proof, as it allows rustc to improve separately.
kkysen
added a commit
that referenced
this pull request
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wrapping arithmetic methods on unsigned integers are stably const now.