Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw tx #62

Merged
merged 2 commits into from
Jun 22, 2019
Merged

Raw tx #62

merged 2 commits into from
Jun 22, 2019

Conversation

cypherhat
Copy link
Member

Description

To support signing binary transaction data, sign-tx method was enhanced to allow transaction data to be read from a file. Also, the packaging of the Vault codebase has changed, so a general refactor to align with the current packaging was performed. As a result, it became apparent that vendoring (go mod vendor) was necessary.

Motivation and Context

The Vault API does not support sending binary data. Thus, reading from a file is necessary.

How Has This Been Tested?

Regression on methods. Compare sign-tx to with data supplied directly vs. data read from file.

Screenshots (if appropriate):

Types of changes

  • Documentation enhancement
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@cypherhat cypherhat merged commit 7bcd2ac into master Jun 22, 2019
@cypherhat cypherhat deleted the raw-tx branch June 22, 2019 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant