Make isArrayLike check more precise to avoid false positives #1520
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1438
Update
isArrayLike
to check for:undefined
)The “accepts an array-like” tests in
List.ts
andSet.ts
both used an array-like object that has a length of 3 and a value set at index 1. This fails the updated logic, which verifies instead that there is a value set at the final index, as opposed to any arbitrary possible index. So, I updated those tests to have a value set at the final index in the array-like objects.I also expanded the
Seq.ts
“accepts an array-like” test to include:{ length: 1, foo: 'bar' }
){ length: 0 }
)