Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [CM-652][Sale Widget] Non-passport wallet gas warning drawer #1785

Merged
merged 7 commits into from
May 17, 2024

Conversation

mimi-imtbl
Copy link
Contributor

@mimi-imtbl mimi-imtbl commented May 16, 2024

Hi👋, please prefix this PR's title with:

  • breaking-change: if you have introduced modification that necessitates immediate adjustments by this SDK's users to their applications, clients, or integrations to avert disruptions to existing features or functionalities.
  • feat:, fix:, refactor:, docs:, or chore:.

A warning drawer when the user chooses to connect with a non-Passport wallet. Only show the drawer to the user once:
Screenshot 2024-05-16 at 2 03 37 PM

@mimi-imtbl mimi-imtbl marked this pull request as ready for review May 16, 2024 05:53
@mimi-imtbl mimi-imtbl requested a review from a team as a code owner May 16, 2024 05:53
jwhardwick
jwhardwick previously approved these changes May 16, 2024
Copy link
Contributor

@jwhardwick jwhardwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @mimi-imtbl

You might want to check your formatter settings - seems like things are getting reformatted unnecessarily.

jhesgodi
jhesgodi previously approved these changes May 17, 2024
@jhesgodi jhesgodi changed the title [feat]cm-652 non-passport wallet gas warning drawer feat: [CM-652][Sale Widget] Non-passport wallet gas warning drawer May 17, 2024
dreamoftrees
dreamoftrees previously approved these changes May 17, 2024
Copy link
Contributor

@dreamoftrees dreamoftrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Noice, just a minor query.

Copy link
Contributor

@dreamoftrees dreamoftrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🍜 🌮

@mimi-imtbl mimi-imtbl added this pull request to the merge queue May 17, 2024
Merged via the queue into main with commit 9d9c103 May 17, 2024
11 checks passed
@mimi-imtbl mimi-imtbl deleted the feat/cm-652-non-passport-wallet-gas-warning branch May 17, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants