Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ID-1732 Fix background blur and append required font links to the head #1797

Merged
merged 3 commits into from
May 20, 2024

Conversation

imx-mikhala
Copy link
Contributor

@imx-mikhala imx-mikhala commented May 17, 2024

Hi馃憢, please prefix this PR's title with:

  • breaking-change: if you have introduced modification that necessitates immediate adjustments by this SDK's users to their applications, clients, or integrations to avert disruptions to existing features or functionalities.
  • feat:, fix:, refactor:, docs:, or chore:.

Summary

  • Fix issue with background not being blurred on Safari & iPhone
  • Append font links to head to import Roboto

Detail and impact of the change

Added

Changed

Deprecated

Removed

Fixed

Security

Anything else worth calling out?

const link3: HTMLLinkElement = document.createElement('link');
link3.href = 'https://fonts.googleapis.com/css2?family=Roboto:ital,wght@0,400;0,500;0,700;1,400;1,500;1,700&display=swap';
link3.rel = 'stylesheet';
document.head.appendChild(link3);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is all the links from the stackblitz

@imx-mikhala imx-mikhala marked this pull request as ready for review May 17, 2024 03:14
@imx-mikhala imx-mikhala requested a review from a team as a code owner May 17, 2024 03:14
oliyoung
oliyoung previously approved these changes May 17, 2024
Copy link
Contributor

@haydenfowler haydenfowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link elements are added to the head element each time the overlay is displayed.
Also, is a preconnect link accurate here if we're only adding the link at the time that the fonts are needed?

@imx-mikhala
Copy link
Contributor Author

imx-mikhala commented May 17, 2024

The link elements are added to the head element each time the overlay is displayed. Also, is a preconnect link accurate here if we're only adding the link at the time that the fonts are needed?

oh good catch i will patch that. think you are right in that preconnect isnt required

@imx-mikhala imx-mikhala added this pull request to the merge queue May 20, 2024
Merged via the queue into main with commit e79ba49 May 20, 2024
15 checks passed
@imx-mikhala imx-mikhala deleted the ID-1732 branch May 20, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants