Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ID-1732 Fix background blur and append required font links to the head #1797

Merged
merged 3 commits into from
May 20, 2024
Merged

fix: ID-1732 Fix background blur and append required font links to the head #1797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ec3350
ID-1732 Fix blur and append required font links to the head
imx-mikhala May 17, 2024
b650748
set id on link to ensure not adding link multiple times
imx-mikhala May 17, 2024
7329b24
remove
imx-mikhala May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions packages/passport/sdk/src/overlay/elements.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ const getOverlay = (contents: string): string => `
height: 100% !important;
background: rgba(13, 13, 13, 0.48) !important;
backdrop-filter: blur(28px) !important;
-webkit-backdrop-filter: blur(28px) !important;
display: flex !important;
flex-direction: column !important;
justify-content: center !important;
Expand Down Expand Up @@ -122,5 +123,28 @@ const getOverlay = (contents: string): string => `
</div>
`;

type LinkParams = {
id: string;
href: string;
rel?: string;
crossOrigin?: string;
};
export function addLink({
id,
href,
rel,
crossOrigin,
}: LinkParams): void {
const fullId = `${PASSPORT_OVERLAY_ID}-${id}`;
if (!document.getElementById(fullId)) {
const link: HTMLLinkElement = document.createElement('link');
link.id = fullId;
link.href = href;
if (rel) link.rel = rel;
if (crossOrigin) link.crossOrigin = crossOrigin;
document.head.appendChild(link);
}
}

export const getBlockedOverlay = () => getOverlay(getBlockedContents());
export const getGenericOverlay = () => getOverlay(getGenericContents());
6 changes: 5 additions & 1 deletion packages/passport/sdk/src/overlay/overlay.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { PopupOverlayOptions } from 'types';
import { PASSPORT_OVERLAY_CLOSE_ID, PASSPORT_OVERLAY_TRY_AGAIN_ID } from './constants';
import { getBlockedOverlay, getGenericOverlay } from './elements';
import { addLink, getBlockedOverlay, getGenericOverlay } from './elements';

export default class Overlay {
private disableGenericPopupOverlay: boolean;
Expand Down Expand Up @@ -48,6 +48,10 @@ export default class Overlay {

private appendOverlay() {
if (!this.overlay) {
addLink({ id: 'link-googleapis', href: 'https://fonts.googleapis.com' });
addLink({ id: 'link-gstatic', href: 'https://fonts.gstatic.com', crossOrigin: 'anonymous' });
addLink({ id: 'link-roboto', href: 'https://fonts.googleapis.com/css2?family=Roboto:ital,wght@0,400;0,500;0,700;1,400;1,500;1,700&display=swap', rel: 'stylesheet' });

const overlay = document.createElement('div');
overlay.innerHTML = this.isBlockedOverlay ? getBlockedOverlay() : getGenericOverlay();
document.body.insertAdjacentElement('beforeend', overlay);
Expand Down
Loading