-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [CM-683][Sale Widget] Fallback token images #1825
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4e83c8a
create tokenImage component
jhesgodi cca7c87
use token image component in summary screen
jhesgodi 2113232
Merge branch 'main' into CM-683-fix-token-images
jhesgodi ca0f2f3
use TokenImage in select form
jhesgodi 4f49f68
use TokenImage in balance item
jhesgodi 3a81817
migrate to use TokenImage
jhesgodi 83412b7
make theme & env optional when defaultImage is provided
jhesgodi 0fc7d89
Merge branch 'main' into CM-683-fix-token-images
jhesgodi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
packages/checkout/widgets-lib/src/components/TokenImage/TokenImage.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
import { useMemo, useState } from 'react'; | ||
import { Environment } from '@imtbl/config'; | ||
import { getDefaultTokenImage } from 'lib/utils'; | ||
import { WidgetTheme } from '@imtbl/checkout-sdk'; | ||
|
||
type ImageProps = { | ||
name?: string; | ||
src?: string; | ||
theme?: WidgetTheme; | ||
environment?: Environment; | ||
defaultImage?: string; | ||
} & ( | ||
| { defaultImage: string; theme?: WidgetTheme; environment?: Environment } | ||
| { defaultImage?: never; theme: WidgetTheme; environment: Environment } | ||
); | ||
|
||
export function TokenImage({ | ||
src, | ||
name, | ||
environment, | ||
theme, | ||
defaultImage, | ||
...forwardedProps | ||
}: ImageProps) { | ||
const [error, setError] = useState<boolean>(false); | ||
const url = useMemo( | ||
() => (!src || error | ||
? defaultImage | ||
|| (theme && getDefaultTokenImage(environment, theme)) | ||
|| '' | ||
: src), | ||
[src, error], | ||
); | ||
|
||
return ( | ||
<img | ||
src={url} | ||
alt={name} | ||
onError={() => setError(true)} | ||
{...forwardedProps} | ||
/> | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added missing package, picked up from merging
main
was causing eslint to fail