Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [CM-683][Sale Widget] Fallback token images #1825

Merged
merged 8 commits into from
May 31, 2024

Conversation

jhesgodi
Copy link
Contributor

@jhesgodi jhesgodi commented May 24, 2024

Summary

Apply fallback image component to all token images across checkout widgets

dreamoftrees
dreamoftrees previously approved these changes May 26, 2024
Copy link
Contributor

@dreamoftrees dreamoftrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @jhesgodi 👍

@jhesgodi jhesgodi changed the title Cm 683 fix token images fix: [CM-683][Sale Widget] Fallback token images May 31, 2024
@@ -16,6 +16,7 @@
"eslint": "^8.40.0",
"eslint-config-airbnb": "^19.0.4",
"eslint-config-airbnb-typescript": "^17.0.0",
"eslint-plugin-react-refresh": "latest",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added missing package, picked up from merging main was causing eslint to fail

@jhesgodi jhesgodi marked this pull request as ready for review May 31, 2024 01:05
@jhesgodi jhesgodi requested a review from a team as a code owner May 31, 2024 01:05
@jhesgodi jhesgodi enabled auto-merge May 31, 2024 01:05
Copy link
Contributor

@jwhardwick jwhardwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice abstraction 💯

Copy link
Contributor

@dreamoftrees dreamoftrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @jhesgodi

@jhesgodi jhesgodi added this pull request to the merge queue May 31, 2024
Merged via the queue into main with commit 2b9c07e May 31, 2024
11 checks passed
@jhesgodi jhesgodi deleted the CM-683-fix-token-images branch May 31, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants