-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [CM-683][Sale Widget] Fallback token images #1825
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @jhesgodi 👍
@@ -16,6 +16,7 @@ | |||
"eslint": "^8.40.0", | |||
"eslint-config-airbnb": "^19.0.4", | |||
"eslint-config-airbnb-typescript": "^17.0.0", | |||
"eslint-plugin-react-refresh": "latest", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added missing package, picked up from merging main
was causing eslint to fail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice abstraction 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @jhesgodi
Summary
Apply fallback image component to all token images across checkout widgets