-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add SIOP Request features #17
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanderstabel
added
Added
A new feature that requires a minor release.
Enhancement
New feature or improvement to an existing feature
labels
Apr 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! 🥳
2 tasks
This was referenced Apr 24, 2023
daniel-mader
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Added
A new feature that requires a minor release.
Enhancement
New feature or improvement to an existing feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR adds the following features:
RequestUrl
enum type with two variants: one for arequest by value
( theSiopRequest
), and another for arequest by reference
. This last variant is defined by therequest_uri
parameter in the request url.RequestUrlBuilder
which enables easy construction of request urls.validate_request()
method forProvider
. This methodextracts
theSiopRequest
from theRequestUrl
and does some validation of the contents.registration
parameter. This includes proper serialization and deserialization to and from literal formencoded request urls. Theserde_urlencoded
crate does not support serialization for non-primitive types (in this case,Registration
is a custom struct with array fields).decode
method for theValidator
trait which enables validating a JWT using a designated public key.skeptic
crate which enables testing of example code in markdown files.wiremock
mock server.Links to any relevant issues
fixes #12
fixes #13
fixes #14
fixes #16
How the change has been tested
siopv2://idtoken?
prefix) to the newRequestUrl
type. The division of the newProvider::validate_request()
method is also reflected in the unit tests.RequestUrl
s of both variants.RequestUrlBuilder
s.tests
directory which includes a newskeptic.rs
file for testing the rust example in the README file.wiremock
mock server for the README example andRelyingParty
unit test.Definition of Done checklist
Add an
x
to the boxes that are relevant to your changes.